Re: AW: More on elog and error codes - Mailing list pgsql-hackers

From Tom Lane
Subject Re: AW: More on elog and error codes
Date
Msg-id 11498.985109378@sss.pgh.pa.us
Whole thread Raw
In response to AW: More on elog and error codes  (Zeugswetter Andreas SB <ZeugswetterA@wien.spardat.at>)
List pgsql-hackers
Zeugswetter Andreas SB  <ZeugswetterA@wien.spardat.at> writes:
> PGELOG(ERROR, PGSQLSTATE_TYPE, ("type %s cannot be created because it already exists", ...))

> put varargs into parentheses to avoid need for ... macros see Tom's proposal

I'd be inclined to make it

PGELOG((ERROR, PGSQLSTATE_TYPE, "type %s cannot be created because it already exists", ...))

The extra parens are ugly and annoying in any case, but they seem
slightly less so if you just double the parens associated with the
PGELOG call.  Takes less thought than adding a paren somewhere in the
middle of the call.  IMHO anyway...
        regards, tom lane


pgsql-hackers by date:

Previous
From: Larry Rosenman
Date:
Subject: Re: AW: Re: More on elog and error codes
Next
From: The Hermit Hacker
Date:
Subject: Final Call: RC1 about to go out the door ...