Re: UNICODE/UTF-8 on win32 - Mailing list pgsql-hackers-win32

From Tom Lane
Subject Re: UNICODE/UTF-8 on win32
Date
Msg-id 11457.1104520876@sss.pgh.pa.us
Whole thread Raw
In response to UNICODE/UTF-8 on win32  ("Magnus Hagander" <mha@sollentuna.net>)
Responses Re: UNICODE/UTF-8 on win32
Re: UNICODE/UTF-8 on win32
List pgsql-hackers-win32
"Magnus Hagander" <mha@sollentuna.net> writes:
> We know it's broken and won't be fixed for 8.0.

> If we just #ifndef WIN32 the definitions in utils/mb/encnames.c it won't
> be possible to select that encoding, right? Will that have any other
> unwanted effects (such as breaking client encodings)? If not, I suggest
> this is done.

I believe the subscripts in those arrays have to match the encoding
enum type, so you can't just ifdef out individual entries.

> (Or perhaps something can be done in pg_valid_server_encoding?)

Making the valid_server_encoding function reject it might work.
Tatsuo-san would know for sure.

Should we also reject it as a client encoding, or does that work OK?

            regards, tom lane

pgsql-hackers-win32 by date:

Previous
From: "Magnus Hagander"
Date:
Subject: UNICODE/UTF-8 on win32
Next
From: Roland Volkmann
Date:
Subject: Re: UNICODE/UTF-8 on win32