Re: Something fishy about the current Makefiles - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Something fishy about the current Makefiles
Date
Msg-id 11437.1294790687@sss.pgh.pa.us
Whole thread Raw
In response to Re: Something fishy about the current Makefiles  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
Peter Eisentraut <peter_e@gmx.net> writes:
> On tor, 2011-01-06 at 11:57 -0500, Tom Lane wrote:
>> Whilst fooling around with GIN, I have repeatedly observed that doing
>> "make" in src/backend/access/gin, followed by "make install-bin" in
>> src/backend, fails to rebuild the postgres executable --- it just
>> installs the existing one.  A second execution of "make install-bin"
>> does notice that postgres is out of date and rebuilds it.  This
>> procedure for rebuilding after changing one or two .c files has always
>> worked for me before.  I can't avoid the suspicion that the recent
>> changes to make things more parallel-friendly broke something.

> This fixes it, but it's beyond me why.

Further experimentation suggests that *only* subdirectories of access/
are vulnerable to the issue.  I wonder whether this syntax:

> -$(SUBDIROBJS): | $(SUBDIRS:%=%-recursive) ;

is weird with respect to the first SUBDIRS value.  Or maybe it's a plain
old bug in gmake.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Andreas Karlsson
Date:
Subject: Re: Bug in pg_describe_object
Next
From: Tom Lane
Date:
Subject: Re: Bug in pg_describe_object