Re: memory leak in trigger handling (since PG12) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: memory leak in trigger handling (since PG12)
Date
Msg-id 1137299.1684942630@sss.pgh.pa.us
Whole thread Raw
In response to memory leak in trigger handling (since PG12)  (Tomas Vondra <tomas.vondra@enterprisedb.com>)
Responses Re: memory leak in trigger handling (since PG12)
List pgsql-hackers
Tomas Vondra <tomas.vondra@enterprisedb.com> writes:
> While looking for other places allocating stuff in ExecutorState (for
> the UPDATE case) and leaving it there, I found two more cases:

> 1) copy_plpgsql_datums

> 2) make_expanded_record_from_tupdesc
>    make_expanded_record_from_exprecord

> All of this is calls from plpgsql_exec_trigger.

Can you show a test case in which this happens?  I added some
instrumentation and verified at least within our regression tests,
copy_plpgsql_datums' CurrentMemoryContext is always plpgsql's
"SPI Proc" context, so I do not see how there can be a query-lifespan
leak there, nor how your 0003 would fix it if there is.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Wrong results due to missing quals
Next
From: Jeff Davis
Date:
Subject: Re: Order changes in PG16 since ICU introduction