Re: domain constraints and UNKNOWN params - Mailing list pgsql-patches

From Neil Conway
Subject Re: domain constraints and UNKNOWN params
Date
Msg-id 1137043720.9143.123.camel@localhost.localdomain
Whole thread Raw
In response to Re: domain constraints and UNKNOWN params  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: domain constraints and UNKNOWN params
Re: domain constraints and UNKNOWN params
Re: domain constraints and UNKNOWN params
List pgsql-patches
On Wed, 2006-01-11 at 23:31 -0500, Tom Lane wrote:
> This is a good catch, but the patch's added check on targetTyptype is a
> waste of code and cycles.  coerce_to_domain is perfectly capable of
> doing nothing when nothing is called for.

Ah, right. Attached is a corrected patch.

> I wonder whether there is any reasonably simple way to audit the whole
> backend for missing domain processing...

Yeah, I've been thinking along the same lines -- the recent spate of
issues doesn't give me a lot of confidence in the correctness or
completeness of the current implementation. I don't really see a way to
check the code that doesn't require a fair amount of manual auditing,
though...

-Neil


Attachment

pgsql-patches by date:

Previous
From: ITAGAKI Takahiro
Date:
Subject: Re: Free WAL caches on switching segments
Next
From: Tom Lane
Date:
Subject: Re: domain constraints and UNKNOWN params