I said:
> Joe Conway <mail@joeconway.com> writes:
>> I found the following while poking around. RangeVarGetRelid takes a
>> second parameter that is intended to allow it to not fail, returning
>> InvalidOid instead. However it calls LookupExplicitNamespace, which does
>> not honor any such request, and happily generates an error on a bad
>> namespace name:
> ISTR deciding that that was okay, and there was no need to clutter
> LookupExplicitNamespace with an extra parameter. Don't recall the
> reasoning at the moment...
After looking: the only place that calls RangeVarGetRelid with a "true"
second parameter is tcop/utility.c, and it just does it so that it can
give a different error message for the "relation not found" case. Thus,
we don't actually *want* failures other than "relation not found" to
return from RangeVarGetRelid. So the code is right as-is. Perhaps the
comments could stand improvement though, to make it clearer what failOK
is meant to do.
regards, tom lane
