Ranier Vilela <ranier.vf@gmail.com> writes:
> msvc 2019 (64 bits), is worried about it:
> C:\dll\postgres\src\backend\utils\adt\dbsize.c(630,20): warning C4334:
> '<<': resultado de 32-bit shift convertido implicitamente para 64 bits
> (64-bit shift era pretendid
> o?) [C:\dll\postgres\postgres.vcxproj]
Yeah, most/all of the MSVC buildfarm members are showing this warning too.
The previous coding was
Int64GetDatum((int64) (1 << count))
which apparently is enough to silence MSVC, though it makes no difference
as to the actual overflow risk involved.
I'm a bit inclined to make the new code be
NumericGetDatum(int64_to_numeric(INT64CONST(1) << count));
ie do the shift in 64 bits. That's either free or next door to free, and
it allows larger count values to be accepted. The existing callers don't
care of course, but someday somebody might try to expose this function
more widely.
regards, tom lane
