Re: [BUGS] BUG #3829: Wrong index reporting from pgAdmin III (v1.8.0 rev 6766-6767) - Mailing list pgadmin-support

From Tom Lane
Subject Re: [BUGS] BUG #3829: Wrong index reporting from pgAdmin III (v1.8.0 rev 6766-6767)
Date
Msg-id 1109.1198110471@sss.pgh.pa.us
Whole thread Raw
In response to Re: [BUGS] BUG #3829: Wrong index reporting from pgAdmin III (v1.8.0 rev 6766-6767)  (Dave Page <dpage@postgresql.org>)
Responses Re: [BUGS] BUG #3829: Wrong index reporting from pgAdmin III (v1.8.0 rev 6766-6767)  (Dave Page <dpage@postgresql.org>)
List pgadmin-support
Dave Page <dpage@postgresql.org> writes:
> Tom Lane wrote:
>> Just out of curiosity, why is pgAdmin doing it this way at all?
>> Seems it would be a lot easier to use the all-columns form of
>> pg_get_indexdef than to cons up the display from fetches of each
>> column individually.

> We use the data in various UI elements as well as for reverse
> engineering the SQL - it's easier to get it broken down than to parse it
> back out of the complete definition.

Seems like all the more argument for having functions that extract
single pieces of information, rather than several pieces (especially
if some pieces get left off when default).

For the moment I've reverted pg_get_indexdef() to its prior behavior
of printing only the index column key or expression when colno!=0.
We can look at having another function to do the other thing in 8.4.
        regards, tom lane


pgadmin-support by date:

Previous
From: Dave Page
Date:
Subject: Re: [BUGS] BUG #3829: Wrong index reporting from pgAdmin III (v1.8.0 rev 6766-6767)
Next
From: Dave Page
Date:
Subject: Re: [BUGS] BUG #3829: Wrong index reporting from pgAdmin III (v1.8.0 rev 6766-6767)