Re: DROP COLUMN Progress - Mailing list pgsql-hackers

From Tom Lane
Subject Re: DROP COLUMN Progress
Date
Msg-id 10964.1025880140@sss.pgh.pa.us
Whole thread Raw
In response to DROP COLUMN Progress  ("Christopher Kings-Lynne" <chriskl@familyhealth.com.au>)
List pgsql-hackers
"Christopher Kings-Lynne" <chriskl@familyhealth.com.au> writes:
> So, say the 'b' column is renamed to 'dropped_2', then you can do this:

> select dropped_2 from tab;
> select tab.dropped_2 from tab;
> update tab set dropped_2 = 3;
> select * from tab where dropped_2 = 3;

> Where have I missed the COLUMN_IS_DROPPED checks???

Sounds like you aren't checking in the part of the parser that resolves
simple variable references.

> Another thing:  I don't want to name dropped columns 'dropped_...' as I
> think that's unfair on our non-English speaking users.  Should I just use
> 'xxxx' or something?

Don't be silly --- the system catalogs are completely English-centric
already.  Do you want to change all the catalog and column names to
meaningless strings?  Since the dropped columns should be invisible to
anyone who's not poking at the catalogs, I don't see that we are adding
any cognitive load ...
        regards, tom lane




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Proposal: CREATE CONVERSION
Next
From: Tatsuo Ishii
Date:
Subject: Re: Proposal: CREATE CONVERSION