Re: nested xacts and phantom Xids - Mailing list pgsql-patches

From Tom Lane
Subject Re: nested xacts and phantom Xids
Date
Msg-id 10941.1087879350@sss.pgh.pa.us
Whole thread Raw
In response to Re: nested xacts and phantom Xids  (Alvaro Herrera <alvherre@dcc.uchile.cl>)
List pgsql-patches
Alvaro Herrera <alvherre@dcc.uchile.cl> writes:
> On Mon, Jun 21, 2004 at 10:28:59PM -0400, Tom Lane wrote:
>> Also, rather than labeling each entry individually, it might be better
>> to keep a separate list for each level of transaction.  Then instead of
>> relabeling, you'd just concat the subtrans list to its parent's.  Seems
>> like this should be faster and less storage.

> Right, but it makes harder to detect when a duplicate relcache entry is
> going to be inserted.  Judging from the commentary in the file this is
> an issue.

It's only a minor efficiency hack; don't get too tense about avoiding dups.
(We don't bother to check for dup catcache-inval entries at all...)
The only thing I'd suggest you need to preserve is the business about
invalidating catcache before relcache; again that's just an efficiency
hack, but it seems simple enough to be worth doing.

            regards, tom lane

pgsql-patches by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: nested xacts and phantom Xids
Next
From: "Dave Page"
Date:
Subject: Re: [HACKERS] Compile failure with SSL