Re: Win32 tablespace - Mailing list pgsql-patches

Hmmm...updated and tried to rebuild - I get the same error!

It looks like I have the latest src/timezone/Makefile (1.14)

The only thing I am doing that is a bit different perhaps is :

- on  Freebsd performing cvs update -d -P
- followed by ./configure;make dist
- copy the archive to win2000 and build (msys 1.0.10, mingw 3.0.1-1)

regards

Mark

(I guess the next best thing for me to try is a *completely* fresh checkout...)

Quoting Bruce Momjian <pgman@candle.pha.pa.us>:

>
> I just committed the final fix for zic and Claudio has compiled it so
> please grab cvs head and give it a try.
>
> ---------------------------------------------------------------------------
>
> markir@coretech.co.nz wrote:
> > Unfortunately I am still seeing the same error - I can "fix" it by with
> this:
> >
> > *** dirmod.c.orig    Sun Aug  8 17:14:48 2004
> > --- dirmod.c    Sun Aug  8 17:14:59 2004
> > ***************
> > *** 15,20 ****
> > --- 15,21 ----
> >
> *-------------------------------------------------------------------------
> >    */
> >
> > + #define FRONTEND
> >   #ifndef FRONTEND
> >   #include "postgres.h"
> >   #else
> >
> >
> > However using the same patch *solely* on the (copied) src/timezone/dirmod.c
> does
> > *not* fix the issue - I wonder if the linker picking up dirmod.o from
> src/port
> > instead of src/timezone?
> >
> > regards
> >
> > Mark
> >
> > Quoting Bruce Momjian <pgman@candle.pha.pa.us>:
> >
> > >
> > > OK, I have just applied a patch to src/timezone/Makefile which will fix
> > > this by compiling dirmod.c specially like we do in other Makefiles.
> > >
> > > Patch attached.
> > >
> > >
> ---------------------------------------------------------------------------
> > >
> > > markir@coretech.co.nz wrote:
> > > > I get a build failure (win 2000 pro):
> > > >
> > > > gcc -O2 -fno-strict-aliasing -Wall -Wmissing-prototypes
> > > -Wmissing-declarations
> > > > zic.o ialloc.o scheck.o localtime.o -L../../src/port   -lpgport
> -lwsock32
> > > -lm
> > > > -lws2_32 -o zic.exe
> > > > ../../src/port/libpgport.a(dirmod.o)(.text+0xc6):dirmod.c: undefined
> > > reference
> > > > to `pgwin32_backend_usleep'
> > > > ../../src/port/libpgport.a(dirmod.o)(.text+0xe4):dirmod.c: undefined
> > > reference
> > > > to `errstart'
> > > > ../../src/port/libpgport.a(dirmod.o)(.text+0xf2):dirmod.c: undefined
> > > reference
> > > > to `elog_finish'
> > > > ../../src/port/libpgport.a(dirmod.o)(.text+0x11d):dirmod.c: undefined
> > > reference
> > > > to `errstart'
> > > > ../../src/port/libpgport.a(dirmod.o)(.text+0x12b):dirmod.c: undefined
> > > reference
> > > > to `elog_finish'
> > > > ../../src/port/libpgport.a(dirmod.o)(.text+0x1c3):dirmod.c: undefined
> > > reference
> > > > to `pgwin32_backend_usleep'
> > > > ../../src/port/libpgport.a(dirmod.o)(.text+0x1e1):dirmod.c: undefined
> > > reference
> > > > to `errstart'
> > > > ../../src/port/libpgport.a(dirmod.o)(.text+0x1f1):dirmod.c: undefined
> > > reference
> > > > to `elog_finish'
> > > > ../../src/port/libpgport.a(dirmod.o)(.text+0x21c):dirmod.c: undefined
> > > reference
> > > > to `errstart'
> > > > ../../src/port/libpgport.a(dirmod.o)(.text+0x22c):dirmod.c: undefined
> > > reference
> > > > to `elog_finish'
> > > > ../../src/port/libpgport.a(dirmod.o)(.text+0x459):dirmod.c: undefined
> > > reference
> > > > to `errstart'
> > > > ../../src/port/libpgport.a(dirmod.o)(.text+0x4aa):dirmod.c: undefined
> > > reference
> > > > to `errmsg'
> > > > ../../src/port/libpgport.a(dirmod.o)(.text+0x4b4):dirmod.c: undefined
> > > reference
> > > > to `errcode_for_file_access'
> > > > ../../src/port/libpgport.a(dirmod.o)(.text+0x4bc):dirmod.c: undefined
> > > reference
> > > > to `errfinish'
> > > > ../../src/port/libpgport.a(dirmod.o)(.text+0x51a):dirmod.c: undefined
> > > reference
> > > > to `pfree'
> > > > ../../src/port/libpgport.a(dirmod.o)(.text+0x5ea):dirmod.c: undefined
> > > reference
> > > > to `_imp__CurrentMemoryContext'
> > > > ../../src/port/libpgport.a(dirmod.o)(.text+0x5f2):dirmod.c: undefined
> > > reference
> > > > to `MemoryContextAlloc'
> > > > ../../src/port/libpgport.a(dirmod.o)(.text+0x64d):dirmod.c: undefined
> > > reference
> > > > to `_imp__CurrentMemoryContext'
> > > > ../../src/port/libpgport.a(dirmod.o)(.text+0x656):dirmod.c: undefined
> > > reference
> > > > to `MemoryContextStrdup'
> > > > ../../src/port/libpgport.a(dirmod.o)(.text+0x50a):dirmod.c: undefined
> > > reference
> > > > to `pfree'
> > > > make[2]: *** [zic] Error 1
> > > > make[2]: Leaving directory
> > > > `/home/Administrator/develop/c/postgresql-8.0devel/src/timezone'
> > > > make[1]: *** [all] Error 2
> > > > make[1]: Leaving directory
> > > > `/home/Administrator/develop/c/postgresql-8.0devel/src'
> > > > make: *** [all] Error 2
> > > >
> > > >
> > > > Quoting Bruce Momjian <pgman@candle.pha.pa.us>:
> > > > >
> > > > > OK, got them all.  Thanks.  Patch attached.
> > > > >
> > > > > Would someone retest on Win32?
> > > > >
> > > > >
> > >
> ---------------------------------------------------------------------------
> > > > >
> > > > > Andreas Pflug wrote:
> > > > > > Bruce Momjian wrote:
> > > > > > > OK, applied.  I moved the funciton into port/dirmod.c and cleaned
> up
> > > the
> > > > > > > interface for Win32.
> > > > > > >
> > > > > > > Would someone test this on Win32 in case I broke something?
> > > > > >
> > > > > > Yes, something's broken, see patch.
> > > > > >
> > > > > > Second, HAVE_SYMLINK must be defined somewhere (configure?).
> > > > > >
> > > > > > Third, a junction is a directory, not a file, so DROP tablespace
> must
> > > > > > use rmdir, not unlink to remove the junction; see my original
> patch.
> > > > > >
> > > > > > Regards,
> > > > > > Andreas
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > > >
> > > > > > ---------------------------(end of
> > > broadcast)---------------------------
> > > > > > TIP 2: you can get off all lists at once with the unregister
> command
> > > > > >     (send "unregister YourEmailAddressHere" to
> > > majordomo@postgresql.org)
> > > > >
> > > > > --
> > > > >   Bruce Momjian                        |  http://candle.pha.pa.us
> > > > >   pgman@candle.pha.pa.us               |  (610) 359-1001
> > > > >   +  If your life is a hard drive,     |  13 Roberts Road
> > > > >   +  Christ can be your backup.        |  Newtown Square,
> Pennsylvania
> > > 19073
> > > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > > --
> > >   Bruce Momjian                        |  http://candle.pha.pa.us
> > >   pgman@candle.pha.pa.us               |  (610) 359-1001
> > >   +  If your life is a hard drive,     |  13 Roberts Road
> > >   +  Christ can be your backup.        |  Newtown Square, Pennsylvania
> 19073
> > >
> >
> >
> >
> >
>
> --
>   Bruce Momjian                        |  http://candle.pha.pa.us
>   pgman@candle.pha.pa.us               |  (610) 359-1001
>   +  If your life is a hard drive,     |  13 Roberts Road
>   +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
>       subscribe-nomail command to majordomo@postgresql.org so that your
>       message can get through to the mailing list cleanly
>