Re: src/port/snprintf.c: Optimize the common base=10 case in fmtint - Mailing list pgsql-hackers

From Tom Lane
Subject Re: src/port/snprintf.c: Optimize the common base=10 case in fmtint
Date
Msg-id 108921.1635273188@sss.pgh.pa.us
Whole thread Raw
In response to src/port/snprintf.c: Optimize the common base=10 case in fmtint  (Arjan van de Ven <arjan@linux.intel.com>)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2021-10-26 13:51:55 -0400, Tom Lane wrote:
>> I'd be inclined to just hard-wire the three allowed cases, and not have
>> an arbitrary-divisor code path at all.

> Yea, I came to the same conclusion. But I'd implement it by moving the
> division into a separate inline function called from the switch. I tested that
> locally and it works, but I got sidetracked by [1].

Uh, why not just a "switch (base)" around three copies of the loop?
Don't overthink this.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: changes in pgport etc doesn't cause client programs to be relinked
Next
From: Andrew Dunstan
Date:
Subject: Re: CREATEROLE and role ownership hierarchies