Postgres Pro
Downloads
Home   >   mailing lists

Re: src/port/snprintf.c: Optimize the common base=10 case in fmtint - Mailing list pgsql-hackers

From Tom Lane
Subject Re: src/port/snprintf.c: Optimize the common base=10 case in fmtint
Date
Msg-id 106306.1635270715@sss.pgh.pa.us
Whole thread Raw
In response to Re: src/port/snprintf.c: Optimize the common base=10 case in fmtint  (Mark Dilger <mark.dilger@enterprisedb.com>)
Responses Re: src/port/snprintf.c: Optimize the common base=10 case in fmtint  (Arjan van de Ven <arjan@linux.intel.com>)
List pgsql-hackers
Tree view 
Mark Dilger <mark.dilger@enterprisedb.com> writes:
> It appears fmtint only has three options for base, being 10, 16, and 8.  Have you profiled with either of the others
specialcased as well?  I don't see much use in optimizing for octal, but hexadecimal is used quite a bit in wal with
patternslike "%08X%08X%08X". 

I'd be inclined to just hard-wire the three allowed cases, and not have
an arbitrary-divisor code path at all.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: pg_dump versus ancient server versions
Next
From: Andrew Dunstan
Date:
Subject: Re: pg_dump versus ancient server versions