Re: [BUGS] Bug #926: if old postgresql.jar in CLASSPATH, - Mailing list pgsql-jdbc
From | Palle Girgensohn |
---|---|
Subject | Re: [BUGS] Bug #926: if old postgresql.jar in CLASSPATH, |
Date | |
Msg-id | 1061511291.3f45607b09150@webmail.pingpong.net Whole thread Raw |
In response to | Re: [BUGS] Bug #926: if old postgresql.jar in CLASSPATH, (Dave Cramer <Dave@micro-automation.net>) |
List | pgsql-jdbc |
Nop, it will only protect against 1. This is better than nothing. And why would anyone even dream of to put jars in jre/lib/ext? Seems rather error prone to me... Still, the best would be to let ant die or don't care if org.postgresql classes are loaded... /Palle Citerar Dave Cramer <Dave@micro-automation.net>: > I think you are correct, this will not fix 2, is it possible to detect > if a class is present in ant, and fail? > > dave > On Thu, 2003-08-21 at 16:16, Barry Lind wrote: > > Can someone explain to me why this change fixes the problem? > > > > I don't understand why including 'includeAntRuntime="no"' in the javac > > tag will cause the compile to no longer pick up old versions of the > > driver that may be around. There are two cases that I am familiar with > > of this problem: 1) there is a old postgresql jdbc jar file in the > > CLASSPATH environment, and 2) there is an old jar in the jre/lib/ext > > directory. I can see where this patch might prevent 1 (although the > > property name and doc aren't very clear on that) but I don't see how it > > would fix 2. > > > > thanks, > > --Barry > > > > > > Dave Cramer wrote: > > > Yes, agreed > > > > > > Dave > > > On Sun, 2003-08-17 at 09:57, Palle Girgensohn wrote: > > > > > >>It's been in use for the freebsd port for some months now, so I say > > >>yes. ;-) > > >> > > >>/Palle > > >> > > >>lördagen den 16 augusti 2003 kl 22.54 skrev Bruce Momjian: > > >> > > >> > > >>>Is this patch valid for inclusion in jdbc? > > >>> > > >>>----------------------------------------------------------------------- > > > >>>---- > > >>> > > >>>pgsql-bugs@postgresql.org wrote: > > >>> > > >>>>Palle Girgensohn (girgen@pingpong.net) reports a bug with a severity > > >>>>of 3 > > >>>>The lower the number the more severe it is. > > >>>> > > >>>>Short Description > > >>>>if old postgresql.jar in CLASSPATH, ant fails > > >>>> > > >>>>Long Description > > >>>>See http://www.freebsd.org/cgi/query-pr.cgi?pr=48878 > > >>>> > > >>>>If there is an older postgresql.jar file in the ant classpath when > > >>>>building a new postgresql.jar, it will fail. > > >>>> > > >>>>Sample Code > > >>>>Adding includeAntRuntime="no" to the compile target in build.xml, as > > >>>>suggested by Tetsurou Okazaki <okazaki@FreeBSD.org>, fixes the >> > problem > > >>>> > > >>>>--- src/interfaces/jdbc/build.xml~ Sun Oct 20 02:10:55 2002 > > >>>>+++ src/interfaces/jdbc/build.xml Mon Mar 3 12:10:37 2003 > > >>>>@@ -101,7 +101,7 @@ > > >>>> > > >>>> <!-- This is the core of the driver. It is common for all three > > >>>>versions. --> > > >>>> <target name="compile" depends="prepare,check_versions,driver"> > > >>>>- <javac srcdir="${srcdir}" destdir="${builddir}" debug="${debug}"> > > >>>>+ <javac includeAntRuntime="no" srcdir="${srcdir}" > > >>>>destdir="${builddir}" debug="${debug}"> > > >>>> <include name="${package}/**" /> > > >>>> > > >>>> <exclude name="${package}/jdbc1/**" unless="jdbc1"/> > > >>>> > > >>>> > > >>>>No file was uploaded with this report > > >>>> > > >>>> > > >>>>---------------------------(end of > > >>>>broadcast)--------------------------- > > >>>>TIP 3: if posting/reading through Usenet, please send an appropriate > > >>>>subscribe-nomail command to majordomo@postgresql.org so that your > > >>>>message can get through to the mailing list cleanly > > >>>> > > >>> > > >>>-- > > >>> Bruce Momjian | http://candle.pha.pa.us > > >>> pgman@candle.pha.pa.us | (610) 359-1001 > > >>> + If your life is a hard drive, | 13 Roberts Road > > >>> + Christ can be your backup. | Newtown Square, Pennsylvania > > > >>>19073 > > >> > > >> > > >>---------------------------(end of broadcast)--------------------------- > > >>TIP 2: you can get off all lists at once with the unregister command > > >> (send "unregister YourEmailAddressHere" to majordomo@postgresql.org) > > >> > > > > > > > -- > Dave Cramer <Dave@micro-automation.net> > >
pgsql-jdbc by date: