Re: Parallel safety tagging of extension functions - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Parallel safety tagging of extension functions
Date
Msg-id 1056.1465505305@sss.pgh.pa.us
Whole thread Raw
In response to Re: Parallel safety tagging of extension functions  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Parallel safety tagging of extension functions  (Robert Haas <robertmhaas@gmail.com>)
Re: Parallel safety tagging of extension functions  (Andreas Karlsson <andreas@proxel.se>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Sat, May 21, 2016 at 11:45 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Yes, let's fix it.  This will also take care of the questions about
>> whether the GIN/GIST opclass tweaks I made a few months ago require
>> module version bumps.

> Tom, there's a patch for this at
> https://www.postgresql.org/message-id/574F091A.3050800@proxel.se which
> I think you should review, since you were the one who made the tweaks
> involved.  Any chance you can do that RSN?

I've pushed this with some revisions to make the queries more
search-path-safe.  I'm not too happy with the safety of the queries
I see already present from the previous patches.  I think stuff
like this:

UPDATE pg_proc SET proparallel = 's'
WHERE oid = 'min(citext)'::regprocedure;

needs to be more like

UPDATE pg_catalog.pg_proc SET proparallel = 's'
WHERE oid = 'min(citext)'::pg_catalog.regprocedure;
        regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Rename max_parallel_degree?
Next
From: Andres Freund
Date:
Subject: Re: Perf Benchmarking and regression.