Re: [COMMITTERS] pgsql: Forbid setval() during recovery. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Forbid setval() during recovery.
Date
Msg-id 10444.1266683690@sss.pgh.pa.us
Whole thread Raw
Responses Re: [COMMITTERS] pgsql: Forbid setval() during recovery.
List pgsql-hackers
heikki@postgresql.org (Heikki Linnakangas) writes:
> Forbid setval() during recovery. This prevents the PANIC reported  by
> Erik Rijkers. Patch by Andres Freund.

ISTM this is the wrong fix.  The real bug is that setval() doesn't
check XactReadOnly.  Now XactReadOnly is only a "soft" read only
mode, but I don't see an argument for either setval() or nextval()
to be allowed when that's set.

Any objections to changing that?
        regards, tom lane


pgsql-hackers by date:

Previous
From: Jaime Casanova
Date:
Subject: Re: explain and PARAM_EXEC
Next
From: Dimitri Fontaine
Date:
Subject: Re: explain and PARAM_EXEC