Re: [COMMITTERS] pgsql: Forbid setval() during recovery. - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [COMMITTERS] pgsql: Forbid setval() during recovery.
Date
Msg-id 201002201833.56969.andres@anarazel.de
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Forbid setval() during recovery.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Saturday 20 February 2010 17:34:50 Tom Lane wrote:
> heikki@postgresql.org (Heikki Linnakangas) writes:
> > Forbid setval() during recovery. This prevents the PANIC reported  by
> > Erik Rijkers. Patch by Andres Freund.
> 
> ISTM this is the wrong fix.  The real bug is that setval() doesn't
> check XactReadOnly.  Now XactReadOnly is only a "soft" read only
> mode, but I don't see an argument for either setval() or nextval()
> to be allowed when that's set.

> Any objections to changing that?
Not from my side - sounds more sensible...

Andres


pgsql-hackers by date:

Previous
From: Dimitri Fontaine
Date:
Subject: Re: explain and PARAM_EXEC
Next
From: Bruce Momjian
Date:
Subject: Re: PGXS: REGRESS_OPTS=--load-language=plpgsql