Re: Remove confusing commented-defaullts from postgresql.conf - Mailing list pgsql-patches

From Tom Lane
Subject Re: Remove confusing commented-defaullts from postgresql.conf
Date
Msg-id 10371.1089688349@sss.pgh.pa.us
Whole thread Raw
In response to Re: Remove confusing commented-defaullts from postgresql.conf  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: Remove confusing commented-defaullts from postgresql.conf  ("Greg Sabino Mullane" <greg@turnstep.com>)
List pgsql-patches
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Uh, it is my understanding that all lines can't be uncommented.  Some of
> the lines have defaults that are computed, like fsync_method.

Yes, fsync_method shouldn't be uncommented unless you're prepared to put
in the same default value presently computed in xlog.c.  (Now that
initdb is in C, it might not be unreasonable to move the #ifdef hacking
that's in xlog.c over to initdb...)

Also you'd need to make some other adjustments in initdb; IIRC it does
sed-like substitutions that will break if the input is not just so.
I don't recall at the moment but there may be some things of the same
ilk done during "make install".  And check the documentation to see if
any discussion needs updated.

> Anyway, we are too busy to consider this for 7.5 unless someone wants to
> research all these issues.

No reason Greg can't do it if he wants to ... but the .sample file
itself is certainly not all that needs changing.

            regards, tom lane

pgsql-patches by date:

Previous
From: Gavin Sherry
Date:
Subject: Re: Include tablespace information in psql \d footers
Next
From: Simon Riggs
Date:
Subject: Re: PITR Archive Recovery plus WIP PITR