Re: Move tablespace - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Move tablespace
Date
Msg-id 10238.1271811833@sss.pgh.pa.us
Whole thread Raw
In response to Move tablespace  (Simon Riggs <simon@2ndQuadrant.com>)
Responses Re: Move tablespace
List pgsql-hackers
Simon Riggs <simon@2ndQuadrant.com> writes:
> Following patch writes a new WAL record that just says "copy foo to
> newts" and during replay we flush buffers and then re-execute the copy
> (but only when InArchiveRecovery). So the copy happens locally on the
> standby, not copying from primary to standby. We do this just with a
> little refactoring and a simple new WAL message.

And what happens to crash-recovery replay?  You can't have it both ways,
either the data is in WAL or it's missing.

> Objections?

This is NOT the time to be rushing in marginal performance
optimizations.  I don't think you've thought through all the corner
cases anyway.
        regards, tom lane


pgsql-hackers by date:

Previous
From: "Joshua D. Drake"
Date:
Subject: Re: BETA
Next
From: Tom Lane
Date:
Subject: Re: Vacuum cancels autovacuum error message confusing?