Re: pg_upgrade: make the locale comparison more tolerating - Mailing list pgsql-hackers

From Pavel Raiskup
Subject Re: pg_upgrade: make the locale comparison more tolerating
Date
Msg-id 10152755.SVtzXS2QiT@nb.usersys.redhat.com
Whole thread Raw
In response to pg_upgrade: make the locale comparison more tolerant  (Pavel Raiskup <praiskup@redhat.com>)
Responses Re: pg_upgrade: make the locale comparison more tolerating  (Rushabh Lathia <rushabh.lathia@gmail.com>)
Re: pg_upgrade: make the locale comparison more tolerating  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Rushabh, really sorry I have to re-create the patch and thanks a
lot for looking at it!

Looking at the patch once again, I see that there were at least two
problems.  Firstly, I used the equivalent_locale function also on the
encoding values.  Even if that should not cause bugs (as it should result
in strncasecmp anyway), it was not pretty..

The second problem was assuming that the locale specifier "A" is not
longer then locale specifier B.  Comparisons like 'en_US.utf8' with
'en_US_.utf8' would result in success.  Bug resulting from this mistake is
not real probably but it is not nice anyway..

Rather cleaning the patch once more, attached,
Pavel

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Change authentication error message (patch)
Next
From: Harold Giménez
Date:
Subject: Re: proposal: hide application_name from other users