[HACKERS] Update comments in nodeModifyTable.c - Mailing list pgsql-hackers

From Etsuro Fujita
Subject [HACKERS] Update comments in nodeModifyTable.c
Date
Msg-id 10026bc7-1403-ef85-9e43-c6100c1cc0e3@lab.ntt.co.jp
Whole thread Raw
Responses Re: [HACKERS] Update comments in nodeModifyTable.c  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
While working on [1], I noticed that the comment in ExecModifyTable:

                  * Foreign table updates have a wholerow attribute when the
                  * relation has an AFTER ROW trigger.

is not 100% correct because a foreign table has a wholerow attrubute 
when the relation has an AFTER ROW or BEFORE ROW trigger (see 
rewriteTargetListUD).  So I'd propose s/an AFTER ROW trigger/a row-level 
trigger/.  Attached is a patch for that.

Best regards,
Etsuro Fujita

[1] 
https://www.postgresql.org/message-id/a31f779e-9cb8-1ea5-71a6-bca6adbfa6a4%40lab.ntt.co.jp

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: [HACKERS] Bug in ExecModifyTable function and trigger issues forforeign tables
Next
From: Tianzhou Chen
Date:
Subject: [HACKERS] Challenges preventing us moving to 64 bit transaction id (XID)?