Re: Remove unnecessary 'always:' from CompilerWarnings task - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Remove unnecessary 'always:' from CompilerWarnings task
Date
Msg-id 0fd7f15c-ac65-4e0b-93b7-fd0eb5df1dcf@eisentraut.org
Whole thread Raw
In response to Remove unnecessary 'always:' from CompilerWarnings task  (Nazir Bilal Yavuz <byavuz81@gmail.com>)
Responses Re: Remove unnecessary 'always:' from CompilerWarnings task
List pgsql-hackers
On 05.09.23 12:25, Nazir Bilal Yavuz wrote:
> There are multiple 'always:' keywords under the CompilerWarnings task.
> Instead of that, we can use one 'always:' and move the instructions
> under this. So, I removed unnecessary ones and rearranged indents
> according to that change.

I'm not sure this change is beneficial.  The way the code is currently 
arranged, it's a bit easier to move or change individual blocks, and 
it's also easier to read the file, because the "always:" is next to each 
"script" and doesn't scroll off the screen.




pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: GenBKI emits useless open;close for catalogs without rows
Next
From: David Rowley
Date:
Subject: Re: ensure, not insure