On 12/28/22 6:24 PM, Andres Freund wrote:
> Hi,
>
> When one uses an itemizedlist inside a table row with
> role="catalog_table_entry", the indentation in the website style sheet
> over-indents the contents of the generated <p>. See
> e.g. pg_stat_replication.state's docs:
> https://www.postgresql.org/docs/devel/monitoring-stats.html#MONITORING-PG-STAT-REPLICATION-VIEW
>
> Note the large padding-left before 'startup', 'catchup', etc.
>
> This is caused by the following rule in the website stylesheet:
> padding-left: 4em;
>
https://git.postgresql.org/gitweb/?p=pgweb.git;a=blob;f=media/css/main.css;h=3ae2b505b401662624a9f073e37646123ebc0d0e;hb=HEAD#l1055
>
> which doesn't just apply to <p>'s directly inside catalog_table_entry, but to
> everything below it as well. Leading to said indentation.
>
> I wonder if the rule should be changed to be > p?
>
>
> I'm a bit confused by the approach of padding-left: 4em; which is then undone
> by text-indent: -3.5em;. Why not just set padding-left to something reasonable
> for .. p.column_definition?
The bigger question I have is why there are <p> blocks inside of <li>.
That does not seem correct, but I believe that would have to be adjusted
from the generation, and I seem to recall that this is a common pattern
in the SGML.
(FWIW, when I remove the <p> tag from the <li>, the indentation is no
longer an issue).
I agree that the padding doesn't belong there. This was added as a part
of [1] when we re-styled the tables.
I think this needs a new rule, i.e:
#docContent table.table th.catalog_table_entry .listitem > p,
#docContent table.table td.catalog_table_entry .listitem > p {
padding-left: 0em;
}
which seems to preserve the other formatting bits that the entry needs
from the original rule, but handles the padding.
Jonathan
[1]
https://git.postgresql.org/gitweb/?p=pgweb.git;a=commit;f=media/css/main.css;h=93716f2a817dbdae8cccf86bc951b45b68ea52d9
