Re: Allow pg_archivecleanup to remove backup history files - Mailing list pgsql-hackers

On 2023/05/31 10:51, torikoshia wrote:
> Update the patch according to the advice.

Thanks for updating the patches! I have small comments regarding 0002 patch.

+       <para>
+         Remove backup history files.

Isn't it better to document clearly which backup history files to be removed? For example, "In addition to removing WAL
files,remove backup history files with prefixes logically preceding the oldestkeptwalfile.".
 


      printf(_("  -n, --dry-run               dry run, show the names of the files that would be removed\n"));
+    printf(_("  -b, --clean-backup-history  clean up files including backup history files\n"));

Shouldn't -b option be placed in alphabetical order?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION