On 2025/07/22 14:29, Fujii Masao wrote:
> On Mon, Jul 21, 2025 at 5:51 PM Álvaro Herrera <alvherre@kurilemu.de> wrote:
>>
>> On 2025-Jul-21, Fujii Masao wrote:
>>
>>> Thanks for updating the patch! It looks good to me, except for one minor point:
>>>
>>> static inline PGresult *libpqsrv_get_result(PGconn *conn, uint32 wait_event_info);
>>> +static inline void libpqsrv_notice_receiver(void *arg, const PGresult *res);
>>>
>>> This prototype is only needed if the function is used earlier in libpq-be-fe-helpers.h,
>>> but that's not the case here, so I don't think it's necessary.
>>>
>>> Unless there are objections, I'll remove that prototype and commit the patch.
>>
>> LGTM.
>
> I've pushed the patch. Thanks!
The buildfarm member indri reported the following error, which seems related to
the recent changes in dblink. I'll investigate this later.
https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=indri&dt=2025-07-22%2006%3A11%3A16&stg=make-contrib
/Library/Developer/CommandLineTools/usr/bin/make -C intagg all
make[1]: Nothing to be done for `all'.
/opt/local/bin/clang -Wno-ignored-attributes -fno-strict-aliasing -fwrapv -fexcess-precision=standard
-mno-outline-atomics-Wno-unused-command-line-argument -Wno-compound-token-split-by-macro -Wno-format-truncation -O2
-I.-I. -I../../src/include -I/opt/local/include -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX15.5.sdk
-I/opt/local/include/libxml2-I/opt/local/include -I/opt/local/include -I/opt/local/include -I/opt/local/include
-flto=thin-emit-llvm -c -o fuzzystrmatch.bc fuzzystrmatch.c
Undefined symbols for architecture arm64:
"_libintl_gettext", referenced from:
_libpqsrv_notice_receiver in dblink.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [dblink.dylib] Error 1
make: *** [all-dblink-recurse] Error 2
make: *** Waiting for unfinished jobs....
Regards,
--
Fujii Masao
NTT DATA Japan Corporation
