Read Uncommitted regression test coverage - Mailing list pgsql-hackers

From Mark Dilger
Subject Read Uncommitted regression test coverage
Date
Msg-id 0e3b0990-f893-e853-1f7e-98a14d872122@gmail.com
Whole thread Raw
In response to Re: Read Uncommitted  (Mark Dilger <hornschnorter@gmail.com>)
Responses Re: Read Uncommitted regression test coverage  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Over in [1], I became concerned that, although postgres supports
Read Uncommitted transaction isolation (by way of Read Committed
mode), there was very little test coverage for it:

On 12/18/19 10:46 AM, Mark Dilger wrote:
> Looking at the regression tests, I'm surprised read uncommitted gets
> so little test coverage. There's a test in src/test/isolation but
> nothing at all in src/test/regression covering this isolation level.
> 
> The one in src/test/isolation doesn't look very comprehensive.  I'd
> at least expect a test that verifies you don't get a syntax error
> when you request READ UNCOMMITTED isolation from SQL.

The attached patch set adds a modicum of test coverage for this.
Do others feel these tests are worth the small run time overhead
they add?

-- 
Mark Dilger

[1] 
https://www.postgresql.org/message-id/CANP8%2Bj%2BmgWfcX9cTPsk7t%2B1kQCxgyGqHTR5R7suht7mCm_x_hA%40mail.gmail.com

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Read Uncommitted
Next
From: Alvaro Herrera
Date:
Subject: remove unnecessary table_open/close from makeArrayTypeName