On 2021-02-04 01:17, Zhihong Yu wrote:
> Hi,
> + if (attribute->attgenerated && !childatt->attgenerated)
> + ereport(ERROR,
> ...
> + if (attribute->attgenerated && childatt->attgenerated)
> + {
>
> Looks like for the second if statement,
> checking attribute->attgenerated should be enough (due to the check from
> the first if statement).
Thanks for taking a look. I figured the way I wrote it makes it easier
to move the code around or insert other code in the future and doesn't
make it so tightly coupled.
Anyway, I figured out how to take account of generation expressions with
different column orders. I used the same approach that we use for check
constraints. The attached patch is good to go from my perspective.
--
Peter Eisentraut
2ndQuadrant, an EDB company
https://www.2ndquadrant.com/
