Re: meson: Non-feature feature options - Mailing list pgsql-hackers

From Nazir Bilal Yavuz
Subject Re: meson: Non-feature feature options
Date
Msg-id 0d23e027-02dd-4533-7ac7-b5da972a5736@gmail.com
Whole thread Raw
In response to meson: Non-feature feature options  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
List pgsql-hackers
Hi,


On 2/8/23 13:45, Peter Eisentraut wrote:
>
> The problem is that these features now cannot be automatically enabled 
> and behave annoyingly different from other feature options.

Agreed.


> For the 'ssl' option, we have deprecated the --with-openssl option in 
> configure and replaced it with --with-ssl, in anticipation of other 
> SSL implementations.  None of that ever happened or is currently 
> planned AFAICT.  So I suggest that we semi-revert this, so that we can 
> make 'openssl' an auto option in meson.

+1


> For the 'uuid' option, I'm not sure what the best way to address this 
> would.  We could establish a search order of libraries that is used if 
> no specific one is set (similar to libreadline, libedit, in a way).  
> So we'd have one option 'uuid' that is of type feature with default 
> 'auto' and another option, say, 'uuid-library' of type 'combo'.
>

Your suggestion looks good and TCL already has a similar implementation 
with what you suggested:

option('pltcl', type : 'feature', value: 'auto',
   description: 'build with TCL support')

option('tcl_version', type : 'string', value : 'tcl',
   description: 'specify TCL version')


Regards,
Nazir Bilal Yavuz
Microsoft




pgsql-hackers by date:

Previous
From: Tatsuo Ishii
Date:
Subject: Re: make_ctags: use -I option to ignore pg_node_attr macro
Next
From: Alvaro Herrera
Date:
Subject: Re: pgbench: using prepared BEGIN statement in a pipeline could cause an error