Re: Fix pg_stat_reset_single_table_counters function - Mailing list pgsql-hackers

From Kyotaro Horiguchi
Subject Re: Fix pg_stat_reset_single_table_counters function
Date
Msg-id 0c0dfe89-528c-c93f-bd00-e21781336ff0@gmail.com
Whole thread Raw
In response to Re: Fix pg_stat_reset_single_table_counters function  (Masahiro Ikeda <ikedamsh@oss.nttdata.com>)
Responses Re: Fix pg_stat_reset_single_table_counters function
Re: Fix pg_stat_reset_single_table_counters function
List pgsql-hackers
Apologies. In the previous mail, I mistakenly addressed it to the wrong 
recipients. Reposted.

On 2023/08/15 14:13, Masahiro Ikeda wrote:
> On 2023-08-15 11:48, Masahiko Sawada wrote:
>> +COMMENT ON DATABASE :current_database IS 'This is a test comment';
>> -- insert or update in 'pg_shdescription'
>>
>> I think the current_database should be quoted (see other examples
>> where using current_database(), e.g. collate.linux.utf8.sql). Also it
>> would be better to reset the comment after the test.
>
> Thanks! I fixed the issues in the v4 patch.

I'm not sure about others, but I would avoid using the name 
"current_database" for the variable.

I would just use "database" or "db" instead.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center




pgsql-hackers by date:

Previous
From: Masahiro Ikeda
Date:
Subject: Re: Rethink the wait event names for postgres_fdw, dblink and etc
Next
From: Chapman Flack
Date:
Subject: Re: Extract numeric filed in JSONB more effectively