Re: Fix pg_stat_reset_single_table_counters function - Mailing list pgsql-hackers

From Masahiro Ikeda
Subject Re: Fix pg_stat_reset_single_table_counters function
Date
Msg-id 9b5dbfd294a7deabe1323b04fa29f9db@oss.nttdata.com
Whole thread Raw
In response to Re: Fix pg_stat_reset_single_table_counters function  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
List pgsql-hackers
On 2023-08-21 11:33, Kyotaro Horiguchi wrote:
> On 2023/08/15 14:13, Masahiro Ikeda wrote:
>> On 2023-08-15 11:48, Masahiko Sawada wrote:
>>> +COMMENT ON DATABASE :current_database IS 'This is a test comment';
>>> -- insert or update in 'pg_shdescription'
>>> 
>>> I think the current_database should be quoted (see other examples
>>> where using current_database(), e.g. collate.linux.utf8.sql). Also it
>>> would be better to reset the comment after the test.
>> 
> 
> I'm not sure about others, but I would avoid using the name
> "current_database" for the variable.
> 
> I would just use "database" or "db" instead.

Thanks! I agree your comment.
I fixed in v5 patch.

Regards,
-- 
Masahiro Ikeda
NTT DATA CORPORATION
Attachment

pgsql-hackers by date:

Previous
From: Masahiro Ikeda
Date:
Subject: Re: Make --help output fit within 80 columns per line
Next
From: Michael Paquier
Date:
Subject: Re: Fix pg_stat_reset_single_table_counters function