Re: Fix pg_stat_reset_single_table_counters function - Mailing list pgsql-hackers

From Masahiro Ikeda
Subject Re: Fix pg_stat_reset_single_table_counters function
Date
Msg-id 93d14a670cf090c08994f1f4958efa25@oss.nttdata.com
Whole thread Raw
In response to Re: Fix pg_stat_reset_single_table_counters function  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: Fix pg_stat_reset_single_table_counters function
List pgsql-hackers
On 2023-08-15 11:48, Masahiko Sawada wrote:
> On Mon, Aug 14, 2023 at 5:12 PM Masahiro Ikeda 
> <ikedamsh@oss.nttdata.com> wrote:
>> I changed the table to check the stats from pg_database to
>> pg_shdescription
>> because the stats can update via the SQL interface COMMENT command.
> 
> It seems to work well.
> 
> +COMMENT ON DATABASE :current_database IS 'This is a test comment';
> -- insert or update in 'pg_shdescription'
> 
> I think the current_database should be quoted (see other examples
> where using current_database(), e.g. collate.linux.utf8.sql). Also it
> would be better to reset the comment after the test.

Thanks! I fixed the issues in the v4 patch.

Regards,
-- 
Masahiro Ikeda
NTT DATA CORPORATION
Attachment

pgsql-hackers by date:

Previous
From: "Zhijie Hou (Fujitsu)"
Date:
Subject: RE: [PoC] pg_upgrade: allow to upgrade publisher node
Next
From: Pavel Stehule
Date:
Subject: Re: Extract numeric filed in JSONB more effectively