[HACKERS] Redundant check of em_is_child - Mailing list pgsql-hackers

From Amit Langote
Subject [HACKERS] Redundant check of em_is_child
Date
Msg-id 0b4aca64-5098-dfb4-3b13-7325d2414b69@lab.ntt.co.jp
Whole thread Raw
Responses Re: [HACKERS] Redundant check of em_is_child  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
In match_eclasses_to_foreign_key_col(), there is this:

            if (em->em_is_child)
                continue;       /* ignore children here */

ISTM, it might as well be:

            Assert(!em->em_is_child);    /* no children yet */

That's because, I think it's still too early in query_planner() to be
expecting any child EC members.

Thanks,
Amit

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: "Higuchi, Daisuke"
Date:
Subject: Re: [HACKERS] [Bug fix]If recovery.conf hastarget_session_attrs=read-write, the standby fails to start.
Next
From: Pierre-Emmanuel André
Date:
Subject: [HACKERS] PostgreSQL 10beta1 - compilation fails on OpenBSD -current