Re: Improve a few appendStringInfo calls new to v18 - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Improve a few appendStringInfo calls new to v18
Date
Msg-id 0aec6cce-edc9-4fb5-bd18-187ff299fbcb@iki.fi
Whole thread Raw
In response to Improve a few appendStringInfo calls new to v18  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Improve a few appendStringInfo calls new to v18
Re: Improve a few appendStringInfo calls new to v18
List pgsql-hackers
On 10/04/2025 06:51, David Rowley wrote:
> Looks like v18 has grown a few appendStringInfo misusages, e.g. using
> appendStringInfo() when no formatting is needed or just using format
> "%s" instead of using appendStringInfoString().
> 
> I've attached a couple of patches. The 0001 is just my method for
> finding these, not for commit. 

Clever!

> 0002 contains the fixes to commit.
> 
> Any objections to doing this soonish? Or in a few weeks?

Sure, let's do it. Why would we wait?

-- 
Heikki Linnakangas
Neon (https://neon.tech)



pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: 64 bit numbers vs format strings
Next
From: Kirill Reshke
Date:
Subject: Re: speedup COPY TO for partitioned table.