Hi!
>> +1 good idea
>
> +1 that's a good idea. Please add it to the next commitfest!
Thanks!
> You have a typo:
>
> + if (pset.sversion < 10000)
> + {
> + char sverbuf[32];
> +
> + pg_log_error("The server (version %s) does not support
> extended statistics.",
> + formatPGVersionNumber(pset.sversion, false,
> + sverbuf, sizeof(sverbuf)));
> + return true;
> + }
>
> the version test is missing a 0, the feature looks otherwise ok.
Ouch, I fixed on the attached patch.
The new patch includes:
- Fix the version number check (10000 -> 100000)
- Fix query to get extended stats info for sort order
- Add handling [Pattern] e.g \dz stts*
- Add document and regression test for \dz
> How about using \dX rather than \dz?
Thanks for your suggestion!
I'll replace it if I got consensus. :-D
Thanks,
Tatsuro Yamada