Re: list of extended statistics on psql - Mailing list pgsql-hackers

From Tatsuro Yamada
Subject Re: list of extended statistics on psql
Date
Msg-id 0ab933af-ecb5-b1f7-b79f-6a56b563f6a5@nttcom.co.jp_1
Whole thread Raw
In response to Re: list of extended statistics on psql  (Julien Rouhaud <rjuju123@gmail.com>)
Responses Re: list of extended statistics on psql  (Tatsuro Yamada <tatsuro.yamada.tf@nttcom.co.jp>)
List pgsql-hackers
Hi!

>> +1 good idea
> 
> +1 that's a good idea.  Please add it to the next commitfest!

Thanks!


> You have a typo:
> 
> +    if (pset.sversion < 10000)
> +    {
> +        char        sverbuf[32];
> +
> +        pg_log_error("The server (version %s) does not support
> extended statistics.",
> +                     formatPGVersionNumber(pset.sversion, false,
> +                                           sverbuf, sizeof(sverbuf)));
> +        return true;
> +    }
> 
> the version test is missing a 0, the feature looks otherwise ok.

Ouch, I fixed on the attached patch.

The new patch includes:

  - Fix the version number check (10000 -> 100000)
  - Fix query to get extended stats info for sort order
  - Add handling [Pattern] e.g \dz stts*
  - Add document and regression test for \dz
  
> How about using \dX rather than \dz?

Thanks for your suggestion!
I'll replace it if I got consensus. :-D

Thanks,
Tatsuro Yamada

Attachment

pgsql-hackers by date:

Previous
From: John Naylor
Date:
Subject: Re: factorial function/phase out postfix operators?
Next
From: Michael Paquier
Date:
Subject: Re: Documentation patch for backup manifests in protocol.sgml