Re: Compiling extensions on Windows - Mailing list pgsql-hackers

<p dir="ltr">If libintl.h and any headers it in turn includes are bundled, there is no longer an issue with NLS. <p
dir="ltr">Thatwas just a workaround for building exts when Pg's headers tried to refer to nonexistent headers when NLS
wasenabled.<div class="quote">On 6 Jan 2014 18:57, Sandeep Thakkar <sandeep.thakkar@enterprisedb.com> wrote:<br
type="attribution"/><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc
solid;padding-left:1ex"><divdir="ltr">Sure. I'll make the changes so that the next available Windows installers include
lbintl.hin $Installdir/include. How about the changes with respect to NLS?<br /><div class="gmail_extra"><br /><br
/><divclass="gmail_quote"> On Mon, Jan 6, 2014 at 2:44 PM, Dave Page <span dir="ltr"><<a
href="mailto:dpage@pgadmin.org"target="_blank">dpage@pgadmin.org</a>></span> wrote:<br /><blockquote
class="gmail_quote"style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Mon, Jan 6,
2014at 3:32 AM, Craig Ringer <<a href="mailto:craig@2ndquadrant.com">craig@2ndquadrant.com</a>> wrote:<br /> >
Hiall<br /> ><br /> > Out of personal interest (in pain and suffering) I was recently looking<br /> > into how
tocompile extensions out-of-tree on Windows using Visual<br /> > Studio (i.e. no PGXS).<br /> ><br /> > It
lookslike the conventional answer to this is "Do a source build of<br /> > PG, compile your ext in-tree in contrib/,
andhope the result is binary<br /> > compatible with release PostgreSQL builds for Windows". Certainly that's<br />
>how I've been doing it to date.<br /> ><br /> > How about everyone else here? Does anyone actually build and
distribute<br/> > extensions out of tree at all?<br /> ><br /> > I'm interested in making the Windows
installerdistributions a bit more<br /> > extension dev friendly. In particular, I'd really like to see EDB's<br />
>Windows installers include the libintl.h for the included libintl, since<br /> > its omission, combined with Pg
beingbuilt with ENABLE_NLS, tends to<br /> > break things horribly. Users can always undefine ENABLE_NLS, but it's
an<br/> > unnecessary roadblock.<br /><br /></div>Sandeep, can you work on fixing this please?<br /><br />
Thanks.<br/><div class="HOEnZb"><div class="h5"><br /> > Are there any objections from -hackers to including 3rd
partyheaders<br /> > for libs we expose in our public headers in the binary distribution?<br /> ><br /> >
Otherthan bundling 3rd party headers, any ideas/suggestions for how we<br /> > might make ext building saner on
Windows?<br/> ><br /> > --<br /> >  Craig Ringer                   <a href="http://www.2ndQuadrant.com/"
target="_blank">http://www.2ndQuadrant.com/</a><br/> >  PostgreSQL Development, 24x7 Support, Training &
Services<br/> ><br /> ><br /></div></div><span class="HOEnZb"><font color="#888888">> --<br /> > Sent via
pgsql-hackersmailing list (<a href="mailto:pgsql-hackers@postgresql.org">pgsql-hackers@postgresql.org</a>)<br /> >
Tomake changes to your subscription:<br /> > <a href="http://www.postgresql.org/mailpref/pgsql-hackers"
target="_blank">http://www.postgresql.org/mailpref/pgsql-hackers</a><br/><br /><br /><br /> --<br /> Dave Page<br />
Blog:<a href="http://pgsnake.blogspot.com" target="_blank">http://pgsnake.blogspot.com</a><br /> Twitter: @pgsnake<br
/><br/> EnterpriseDB UK: <a href="http://www.enterprisedb.com" target="_blank">http://www.enterprisedb.com</a><br />
TheEnterprise PostgreSQL Company<br /></font></span></blockquote></div><br /><br clear="all" /><div><br /></div>-- <br
/><divdir="ltr">Sandeep Thakkar<div><br /></div></div></div></div></blockquote></div>