Re: encode/decode support for base64url - Mailing list pgsql-hackers

From Florents Tselai
Subject Re: encode/decode support for base64url
Date
Msg-id 0F9CC1F5-2CEA-4CA1-9711-43C88E32F796@gmail.com
Whole thread Raw
In response to Re: encode/decode support for base64url  (Aleksander Alekseev <aleksander@tigerdata.com>)
List pgsql-hackers
Thanks for the review Aleksander,

> On 9 Jul 2025, at 10:45 PM, Aleksander Alekseev <aleksander@tigerdata.com> wrote:
>
> Hi Florents,
>
> Thanks for the update!
>
>> here's a v4 patch set
>>
>> - Extracted pg_base64_{en,de}_internal with an  additional bool url param, to be used by other functions
>> - Added a few more test cases
>>
>> Cary mentioned above
>>
>>> In addition, you may also want to add the C versions of base64rul encode
>> and decode functions to "src/common/base64.c" as new API calls
>>
>> Haven't done that, but I could;
>> Although I think it'd probably be best to do it in a separate patch.
>
> I reviewed and tested v4. To me it looks as good as it will get.
> Personally I would change a few minor things here and there and
> probably merge all three patches into a single commit. This however is
> up to the committer to decide.

Attaching a single-file patch


> 
> Changing the CF entry status to "RfC".


Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Using failover slots for PG-non_PG logical replication
Next
From: Michael Paquier
Date:
Subject: Re: Fix comment in btree_gist--1.8--1.9.sql