Re: A small tweak to some comments for PartitionKeyData - Mailing list pgsql-hackers

From Amit Langote
Subject Re: A small tweak to some comments for PartitionKeyData
Date
Msg-id 09fb365a-c8ec-bf9e-8f9b-118afbb33d74@lab.ntt.co.jp
Whole thread Raw
In response to Re: A small tweak to some comments for PartitionKeyData  (David Rowley <david.rowley@2ndquadrant.com>)
List pgsql-hackers
On 2018/10/25 13:13, David Rowley wrote:
> On 25 October 2018 at 17:05, Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> wrote:
>> On 2018/10/25 12:54, David Rowley wrote:
>>> On 25 October 2018 at 16:46, Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> wrote:
>>>> +                                                                * key, one for each zero-valued partattrs */
>>>>
>>>> How about: for each zero-valued member of partattrs?
>>>
>>> Aren't arrays made up of elements?   I did have "element" on the end,
>>> but I didn't think it was worth having the extra line caused by the 80
>>> line length limit, so I deleted it.
>>>
>>> Seems "element" is mentioned 73 times in [1], but "member" does not
>>> get a mention.
>>>
>>> [1] https://en.wikipedia.org/wiki/Array_data_structure
>>
>> I thought they can be used interchangeably, but perhaps not.
> 
> A struct or a class has members.

You're right.

Thanks,
Amit



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: A small tweak to some comments for PartitionKeyData
Next
From: "Nagaura, Ryohei"
Date:
Subject: RE: Timeout parameters