Postgres Pro
Downloads
Home   >   mailing lists

Re: Avoid extra Sort nodes between WindowAggs when sorting can bereused - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Avoid extra Sort nodes between WindowAggs when sorting can bereused
Date
Msg-id 09AAAA20-F9AB-4F15-98A8-04B146BED6FE@yesql.se
Whole thread Raw
In response to Re: Avoid extra Sort nodes between WindowAggs when sorting can be reused  (Andrew Gierth <andrew@tao11.riddles.org.uk>)
List pgsql-hackers
Tree view 
> On 12 Sep 2018, at 22:15, Andrew Gierth <andrew@tao11.riddles.org.uk> wrote:

> WindowClauseSortNode - I don't like this name, because it's not actually
> a Node of any kind. How about WindowSortData?

That’s a good point.  I probably would’ve named it WindowClauseSortData since
it acts on WindowClauses, but that might just be overly verbose.

> Any comments? (no need to post further patches unless there's some major
> change needed)

I have no objections to the comments made in this review, only the above
nitpick.

Thanks for picking this up!

cheers ./daniel

pgsql-hackers by date:

Previous
From: Andrew Gierth
Date:
Subject: Re: Avoid extra Sort nodes between WindowAggs when sorting can be reused
Next
From: Andres Freund
Date:
Subject: Re: [patch] Support LLVM 7