[PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdwmessage. - Mailing list pgsql-hackers

From Gilles Darold
Subject [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdwmessage.
Date
Msg-id 08600ed3-3084-be70-65ba-279ab19618a5@darold.net
Whole thread Raw
Responses Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdwmessage.  (Michael Paquier <michael@paquier.xyz>)
Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message.  (Etsuro Fujita <etsuro.fujita@gmail.com>)
List pgsql-hackers

Hi,


As per the following code, t1 is a remote table through postgres_fdw:


test=# BEGIN;
BEGIN
test=# SELECT * FROM t1;
...

test=# PREPARE TRANSACTION 'gxid1';
ERROR:  cannot prepare a transaction that modified remote tables


I have attached a patch to the documentation that adds remote tables to the list of objects where any operation prevent using a prepared transaction, currently it is just notified "operations involving temporary tables or the session's temporary namespace".


The second patch modify the message returned by postgres_fdw as per the SELECT statement above the message should be more comprehensible with:

    ERROR:  cannot PREPARE a transaction that has operated on remote tables

like for temporary objects:

    ERROR:  cannot PREPARE a transaction that has operated on temporary objects


Best regards,

--

Gilles

-- 
Gilles Darold
http://www.darold.net/
Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: On disable_cost
Next
From: Robert Haas
Date:
Subject: Re: [PATCH] Implement INSERT SET syntax