Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows
Date
Msg-id 077756d1-c6af-4a59-a3f8-5f152ddabd08@iki.fi
Whole thread Raw
In response to Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 25/12/2024 18:34, Tom Lane wrote:
> Heikki Linnakangas <hlinnaka@iki.fi> writes:
>> Ok, committed that, thanks1
> 
> The question this patch brings to my mind is whether libpgport
> doesn't need the same treatment.

Good point. Yes it does.

I tested that by adding a dummy call to COMP_CRC32C() in a test module, 
and letting cirrus CI build it:

[17:10:32.715] dummy_index_am.c.obj : error LNK2001: unresolved external 
symbol pg_comp_crc32c

Committed the same fix for libpqport.

-- 
Heikki Linnakangas
Neon (https://neon.tech)




pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Parallel heap vacuum
Next
From: Tomas Vondra
Date:
Subject: Re: PoC: history of recent vacuum/checkpoint runs (using new hooks)