Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64 - Mailing list pgsql-hackers

From NISHIYAMA Tomoaki
Subject Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64
Date
Msg-id 062D1CF0-C3E2-4ACF-8980-982A364D76AD@staff.kanazawa-u.ac.jp
Whole thread Raw
In response to Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64  (NISHIYAMA Tomoaki <tomoakin@staff.kanazawa-u.ac.jp>)
Responses Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Hi,

>>>> +/* __MINGW64_VERSION_MAJOR is related to both 32/64 bit gcc compiles by
>>>> + * mingw-w64, however it gots defined only after
>>>> Why not use __MINGW32__, which is defined without including any headers?
>> 
>> Because it's defined by other than mingw-w64 compilers.
> 
> I see. That's because mingw (not -w64). 
> Should it be ok if mingw is ok with that condition?


This really breaks mingw gcc 4.6.1 :( it does not have crtdefs.h)
If moving downward do not break MSVC, perhaps its the good way.
Otherwise, we might check for the presence of crtdefs.h with configure?



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Patch: Perl xsubpp
Next
From: Andrew Dunstan
Date:
Subject: Re: [COMMITTERS] pgsql: Move pg_dump memory routines into pg_dumpmem.c/h and restore com