Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() - Mailing list pgsql-hackers

From Alena Rybakina
Subject Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop()
Date
Msg-id 0468a156-92c4-4b2b-8475-a573bb8691e1@yandex.ru
Whole thread Raw
In response to Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop()  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers

Hi!

Thank you for your work on the subject.


I reviewed your patch and found that your commit message does not fully explain your code, in addition, I found several spelling mistakes.

I think it's better to change to:With parallel seqscan, we should consider materializing the cheapest inner path in
case of nested loop if it doesn't contain a unique node or it is unsafe to use it in a subquery.


Besides, I couldn't understand why we again check that material path is safe?

if (matpath != NULL && matpath->parallel_safe)
            try_partial_nestloop_path(root, joinrel, outerpath, matpath,
                                      pathkeys, jointype, extra);

-- 
Regards,
Alena Rybakina

pgsql-hackers by date:

Previous
From: Vik Fearing
Date:
Subject: Re: run pgindent on a regular basis / scripted manner
Next
From: Robert Haas
Date:
Subject: Re: Query execution in Perl TAP tests needs work