Re: pgadmin3 query tools - Mailing list pgadmin-hackers

From Dave Page
Subject Re: pgadmin3 query tools
Date
Msg-id 03AF4E498C591348A42FC93DEA9661B885FF@mail.vale-housing.co.uk
Whole thread Raw
In response to pgadmin3 query tools  (Andreas Pflug <Andreas.Pflug@web.de>)
Responses Re: pgadmin3 query tools
List pgadmin-hackers
Hi guys,

> -----Original Message-----
> From: Andreas Pflug [mailto:Andreas.Pflug@web.de]
> Sent: 02 April 2003 01:50
> To: pgadmin-hackers@postgresql.org
> Subject: Re: [pgadmin-hackers] pgadmin3 query tools
>
> >Here are my two cents. We put a "view" menu in BOTH our
> tools.

> That's not far from my solution, switching from one to the
> other with a
> menu/toolbar. We would have two tools, I wouldn't really bother about
> that. As I wrote, the core code could be wrapped into a
> control, either
> derived from wxNotebook or wxListView, whatever is more
> useful.

That's fine with me. My major concern is that the code that drives the
grid is only written once. This is likely to get quite complex once
editting features are added, and I don't want to maintain 2 copies. I
always want to keep the look and feel consistant.

So, how about we create a class derived from the wxNotebook as Andreas
suggests, which can just be passed the completed query to display the
results and allow editting thereof (where possible), and display explain
output (and hopefully one day we can add a visual explain tab).

 There might be another argument towards two distinct
> tools: Porting to
> **ix might be easier.

The biggest problem we're finding in *nix is that the ctor for wxString
doesn't like taking an initial value (iirc).

Mark, I know you're busy, but if you get 5 minutes, can you do an update
and try rebuilding on Linux please? It's possible that there are one or
two source files missing from the Makefile...

> Just tell me where you find something. And I'll find out who's at my
> machine adding that leaks while I'm off-site. Just reviewed all
> ExecuteSet and  found two missing pgSet deletes in pgColumn
> and pgSequence.

Ahh, those pesky code pixies....

Regards, Dave.


pgadmin-hackers by date:

Previous
From: Andreas Pflug
Date:
Subject: Re: pgadmin3 query tools
Next
From: "Dave Page"
Date:
Subject: Re: pgadmin3: present and future