Re: Implement for window functions - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Implement for window functions
Date
Msg-id 02B860B7-E72B-4EF0-8C70-2FC36DD94D80@yesql.se
Whole thread Raw
In response to Implement for window functions  (Vik Fearing <vik@postgresfriends.org>)
Responses Re: Implement for window functions  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
> On 30 Jun 2020, at 15:54, Vik Fearing <vik@postgresfriends.org> wrote:

> This feature adds RESPECT NULLS and IGNORE NULLS syntax to several
> window functions, according to the SQL Standard.

This fails compilation due to a compiler warning in WinGetFuncArgInPartition
and WinGetFuncArgInFrame (same warning in both):

nodeWindowAgg.c: In function ‘WinGetFuncArgInPartition’:
nodeWindowAgg.c:3274:10: error: ‘step’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
   relpos += step;
          ^
This was with GCC in the Travis build, the Windows build passed and so does
clang locally for me.

cheers ./daniel


pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: Identifying user-created objects
Next
From: Daniel Gustafsson
Date:
Subject: Re: Make MemoryContextMemAllocated() more precise