Re: [HACKERS] logical replication worker and statistics - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [HACKERS] logical replication worker and statistics
Date
Msg-id 016aba9e-1171-247c-8e51-c8228b6ae27f@2ndquadrant.com
Whole thread Raw
In response to Re: [HACKERS] logical replication worker and statistics  (Petr Jelinek <petr.jelinek@2ndquadrant.com>)
List pgsql-hackers
On 4/14/17 12:09, Petr Jelinek wrote:
> Indeed, if catchup phase didn't happen (because tablesync was faster
> than apply) then the commit handler is never called so all the changes
> made by copy would be forgotten. Also the tablesync worker might exit
> from process_syncing_tables() call which is called before we report
> stats in the commit handler so again some changes might be forgotten.
> 
> I attached modified version of the patch that also reports stats in
> finish_sync_worker() when there is outstanding transaction. The test can
> stay the same.

committed (without the tests)

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Petr Jelinek
Date:
Subject: Re: [HACKERS] logical replication and PANIC during shutdowncheckpoint in publisher
Next
From: Magnus Hagander
Date:
Subject: Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build