Re: pgsql: Avoid unsatisfied-external-reference errors in static inlines. - Mailing list pgsql-committers

From Peter Eisentraut
Subject Re: pgsql: Avoid unsatisfied-external-reference errors in static inlines.
Date
Msg-id 01214fad-1249-183c-2161-837d8f1c1de0@enterprisedb.com
Whole thread Raw
In response to Re: pgsql: Avoid unsatisfied-external-reference errors in static inlines.  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Responses Re: pgsql: Avoid unsatisfied-external-reference errors in static inlines.
List pgsql-committers
On 14.07.22 12:05, Peter Eisentraut wrote:
> On 13.07.22 20:24, Tom Lane wrote:
>> Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
>>> What platforms did this fail on?  How can one observe the failure 
>>> locally?
>>
>> wrasse at least:
>>
>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=wrasse&dt=2022-07-13%2014%3A49%3A17 
>>
>>
>> I think possibly you could duplicate the problem with gcc
>> by using -fkeep-inline-functions, but I've not tried.
> 
> Confirmed, -fkeep-inline-functions will catch it.  Good to know.

It seems that -fkeep-inline-functions is more demanding than what wrasse 
is running on.  I need the attached patch to get it to build cleanly.

(The first hunk undoes some parts of 
2cd2569c72b8920048e35c31c9be30a6170e1410, but the others are unrelated 
and old.)

I think this would be good to apply so that this method of checking 
inline functions is available in the future.
Attachment

pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: pgsql: Don't clobber postmaster sigmask in dsm_impl_resize.
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Avoid unsatisfied-external-reference errors in static inlines.