Re: Suggestions for implementing IS DISTINCT FROM? - Mailing list pgsql-hackers

From Christopher Kings-Lynne
Subject Re: Suggestions for implementing IS DISTINCT FROM?
Date
Msg-id 009101c21b31$826db310$0200a8c0@SOL
Whole thread Raw
In response to Suggestions for implementing IS DISTINCT FROM?  (Thomas Lockhart <lockhart@fourpalms.org>)
Responses Re: Suggestions for implementing IS DISTINCT FROM?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> Please, please, do not do that.  Make a new expression node tree type,
> instead.  We've made this mistake before (eg for BETWEEN) and I don't
> want to do it again.

I've actually already done almost all the work for converting BETWEEN to a
node but I have a couple of questions:

Should I use a boolean in the node to indicate whether it is SYMMETRIC or
ASYMMETRIC, or should I use some sort of integer to indicate whether it is
SYMMETRIC, ASYMMETRIC or DEFAULT (ASYMMETRIC).  That way the reverse in
rules and views could leave out the ASYMMETRIC if it wasn't specified
originally, rather than always adding it in.  Which is better?

Chris






pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: A fairly obvious optimization?
Next
From: "David M. Kaplan"
Date:
Subject: ident-des patches