Re: Rename of triggers for partitioned tables - Mailing list pgsql-hackers

From Arne Roland
Subject Re: Rename of triggers for partitioned tables
Date
Msg-id 004683a28e714bf3beb9a413a2ffbcb9@index.de
Whole thread Raw
In response to Re: Rename of triggers for partitioned tables  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: Rename of triggers for partitioned tables  (Arne Roland <A.Roland@index.de>)
Re: Rename of triggers for partitioned tables  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers

Hi!


From: Alvaro Herrera <alvherre@alvh.no-ip.org>
Sent: Tuesday, July 20, 2021 02:03
To: Arne Roland
Cc: vignesh C; Zhihong Yu; Pg Hackers
Subject: Re: Rename of triggers for partitioned tables
 
I found this coding too convoluted, so I rewrote it in a different way.
You tests pass with this, but I admit I haven't double-checked them yet;
I'll do that next.

Is your patch based on master? It doesn't apply at my end.

I don't think we need to give a NOTICE when the trigger name does not
match; it doesn't really matter that the trigger was named differently
before the command, does it?

I'd expect the command
ALTER TRIGGER name ON table_name RENAME TO new_name;
to rename a trigger named "name". We are referring the trigger via it's name after all. If a child is named differently we break with that assumption. I think informing the user about that, is very valuable.

Regards
Arne

pgsql-hackers by date:

Previous
From: Greg Nancarrow
Date:
Subject: Re: row filtering for logical replication
Next
From: Tom Lane
Date:
Subject: Re: O_DIRECT on macOS