Re: win32.mak patch - Mailing list pgsql-patches

From Hiroshi Saito
Subject Re: win32.mak patch
Date
Msg-id 002301c842a3$fb91fbd0$c601a8c0@HP22720319231
Whole thread Raw
In response to win32.mak patch  ("Hiroshi Saito" <z-saito@guitar.ocn.ne.jp>)
Responses Re: win32.mak patch  (Magnus Hagander <magnus@hagander.net>)
List pgsql-patches
Hi.

----- Original Message -----
From: "Magnus Hagander" <magnus@hagander.net>


> On Wed, Dec 19, 2007 at 11:19:54AM +0900, Hiroshi Saito wrote:
>> Ummm, Sorry...former patch to be disregarded.
>> Although 64bit mak is experimental, it needs to be compiled.
>> Please apply this.
>
> Is this really correct? Fromw hat I can tell you *both* tell us not to
> check the value *and* set the value? Shouldn't we be doing just one of
> them?

The setup is not allowed in 64-bit build of VisualStudio. Then, It is not
allowed although I use nmake. I did the work of 64-bit correspondence
of 8.3 to libpq. However, Although it is not declared by release, win32.mak
has. I said that 64 bits of libpq(s) were required, in order that psqlODBC
might guide 64 bits formally. Then, I and Inoue-san have lost timing in the
reason for not having sufficient examination environment. But, We have
compile environment. Then, It borrows an external machine and has performed
only the easy examination....

-- add the _USE_32BIT_TIME_T  for 64bit compile environment --

        echo #define SYSCONFDIR "" > pg_config_paths.h
        cl.exe /nologo /W3 /EHsc /O2 /MD /I "..\..\include" /I "..\..\include\po
rt\win32" /I "..\..\include\port\win32_msvc" /I "..\..\port" /I. /I "C:\OpenSSL\
include"  /D "FRONTEND" /D NDEBUG /D _USE_32BIT_TIME_T  /D "WIN32" /D "_WINDOWS"
 /Fp".\Release\libpq.pch"  /Fo".\Release\\" /Fd".\Release\\" /FD /c   /D "_CRT_S
ECURE_NO_DEPRECATE" /D "WIN64" /Wp64 /GS /D ENABLE_THREAD_SAFETY "win32.c"
win32.c
C:\Program Files\Microsoft Visual Studio 8\VC\include\crtdefs.h(493) : fatal err
or C1189: #error :  You cannot use 32-bit time_t (_USE_32BIT_TIME_T) with _WIN64

NMAKE : fatal error U1077: 'cl.exe' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Platform SDK\Bin\nmake.e
xe"' : return code '0x2'
Stop.

-- END --

I'm always realistic. what do you think?

Regards,
Hiroshi Saito

pgsql-patches by date:

Previous
From: "Joshua D. Drake"
Date:
Subject: Re: [HACKERS] Proposal for Null Bitmap Optimization(for TrailingNULLs)
Next
From: "Gokulakannan Somasundaram"
Date:
Subject: Re: [HACKERS] Proposal for Null Bitmap Optimization(for TrailingNULLs)