create database doesn't work well in MULTIBYTE mode - Mailing list pgsql-hackers

From Hiroshi Inoue
Subject create database doesn't work well in MULTIBYTE mode
Date
Msg-id 000501bf78df$dbb55f00$2801007e@tpf.co.jp
Whole thread Raw
Responses Re: [HACKERS] create database doesn't work well in MULTIBYTE mode
Re: [HACKERS] create database doesn't work well in MULTIBYTE mode
List pgsql-hackers
Hi

I have a crash while creating regression database in pararell regression
test.
Seems it's due to the following change.

@@ -2638,7 +2705,14 @@                    n->dbname = $3;                    n->dbpath = $5;#ifdef MULTIBYTE
-                    n->encoding = $6;
+                    if ($6 != NULL) {
+                        n->encoding = pg_char_to_encoding($6);
+                        if (n->encoding < 0) {
+                            elog(ERROR, "Encoding name '%s' is invalid", $6);
+                        }
+                    } else {
+                        n->encoding = GetTemplateEncoding();
+                    }#else                    n->encoding = 0;#endif

Why ?
$6 is an ival not an str.

Regards.

Hiroshi Inoue
Inoue@tpf.co.jp



pgsql-hackers by date:

Previous
From: "Hiroshi Inoue"
Date:
Subject: RE: [HACKERS] Solution for LIMIT cost estimation
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] Maximum columns for optimum performance (fwd)